Skip to content

Sheffield | 26-ITP-Jan | Karim M'hamdi | Sprint 2 | Module-Data-Groups#1061

Closed
KKtech06 wants to merge 6 commits intoCodeYourFuture:mainfrom
KKtech06:coursework/sprint-2
Closed

Sheffield | 26-ITP-Jan | Karim M'hamdi | Sprint 2 | Module-Data-Groups#1061
KKtech06 wants to merge 6 commits intoCodeYourFuture:mainfrom
KKtech06:coursework/sprint-2

Conversation

@KKtech06
Copy link
Copy Markdown

@KKtech06 KKtech06 commented Mar 21, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist: Resolved issues following feedback instructions

Questions

N/A

@KKtech06 KKtech06 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
Comment thread Sprint-2/debug/recipe.js Outdated
Comment thread Sprint-2/implement/contains.js Outdated
Comment thread Sprint-2/implement/contains.test.js
Comment thread Sprint-2/implement/querystring.js
Comment thread Sprint-2/implement/tally.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 28, 2026
@KKtech06 KKtech06 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 29, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Mar 29, 2026

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 29, 2026
@illicitonion
Copy link
Copy Markdown
Member

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants